Due to a ransomware attack, the wiki was reverted to a July 2022 version. . We apologize for the lack of a more recent valid backup.
...
| Table of Contents | ||
|---|---|---|
|
- Guidelines
- Coding
- unit testing
- Code Review
- Sample Gerrit Workflow
Licensing and Contributor Agreement
...
The ONOS project uses Gerrit for code review. Once submitted, a patch is changeset is inspected by core ONOS developers. Who reviews the submitted changeset depends on several criteria. For example, the reviewers for a changeset involving the existing codebase will likely include current maintainers of the particular subsystems that the changeset affects.
Feedback
The primary mode for feedback is via email.
For a changeset to be accepted, it must receive one review with a +2 (not to be confused with two reviews of +1). A changeset given a -2 will not be accepted.
Code submission
The process of submitting code and amending changesets is described in the Sample Workflow.