Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Table of Contents
maxLevel3

Licensing and Contributor Agreement

...

The ONOS project uses Gerrit for code review. Once submitted, a changeset is inspected by core ONOS developers. Who reviews the submitted changeset depends on several criteria. For example, the reviewers for a changeset involving modifications to the existing codebase will likely include current maintainers of the particular subsystems that the changeset affects. Reviewers of new additions, e.g. applications, subsystems, and providers, will depend on where and how the new changeset will affect in the existing codebase, as well as who, if any, has provided guidance during the development process. 

Feedback

The primary mode for feedback is via email. Therefore, it is important to have the email configured in user settings, and to be subscribed to notifications. 

For a changeset to be accepted, it must receive one review with a +2 (not to be confused with two reviews of +1). A changeset given a -2 will not be accepted. 

...

The process of submitting code and amending changesets using the git Gerrit plugin is described in the Sample Workflow.