Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Table of Contents
maxLevel3

Getting ONOS source code

Developers should check out ONOS source, as per Getting ONOS - ONOS Source Code.

Licensing and Contributor Agreement

...

All available unit tests are run as part of a full build process. Contributions should pass all tests and build successfully before being submitted. 

The full guidelines for unit tests can be found [here].

Code Review

The ONOS project uses Gerrit for code review. Once submitted, a changeset is inspected by core ONOS developers. Who reviews the submitted changeset depends committers. The reviewers of a submitted patch, or changeset, depend on several criteria. For example, the reviewers for modifications to the existing codebase will likely include current maintainers of the particular subsystems that the changeset affects. Reviewers of new additions, e.g. applications, subsystems, and providers, will depend on where and how the new changeset will affect the existing codebase, as well as who, if any, has provided guidance during the development process of the changeset

Feedback

The primary mode for feedback is via email. This includes notifications about changeset acceptance and rejection, as well as reviewer comments that should be addressed. Therefore, it is important to 1) be subscribed to the project, and 2) have email notifications configured in user settings.  Development Environment Setup addresses Git/Gerrit Setup addresses the configuration of Gerrit. 

...