master-SR Link Failure with Stratum BMv2 switches

commit 924f01f31f8302a8680a6a16f1e43d56e469bd4f (HEAD -] master, origin/master, origin/HEAD)
Author: Anurag Chadha [anurag.chadha@hsc.com]
AuthorDate: Fri Dec 4 19:48:56 2020 +0530
Commit: Thomas Vachuska [tom@opennetworking.org]
CommitDate: Fri Jan 8 00:54:25 2021 +0000

[ONOS-8129] Bug fixed for duplicate events when netconf device goes down along with some fixes for NPE in NetconfControllerImpl

Case 1: Bridging and Routing Link Failure test with 2x2 Leaf-spine and 1 Onos - FAIL

• 1.1 Constructing test variables - PASS
• 1.2 Apply cell to environment - PASS
• 1.3 Uninstalling Atomix - PASS
• 1.4 Uninstalling ONOS package - PASS
• 1.5 Building ONOS Docker image - PASS
• 1.6 Create Cluster Config - PASS
• 1.7 Installing Atomix via docker containers - PASS
• 1.8 Installing ONOS via docker containers - PASS
• 1.9 Set up ONOS secure SSH - PASS
• 1.10 Starting ONOS CLI sessions - PASS
• 1.11 Checking ONOS nodes - PASS
• 1.12 Checking ONOS applications - PASS
• 1.13 Set logging levels - PASS
• 1.14 Set ONOS configurations - PASS
• 1.15 Starting Mininet Topology - PASS
• 1.16 Configure switches in ONOS - PASS
• 1.17 Check number of topology elements - PASS
• 1.18 Check whether the flow count is >= 116 - PASS
• 1.19 Check whether all flow status are ADDED - PASS
• 1.20 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4'] with tag CASE1 - FAIL
• IP connectivity failed
• 1.21 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE1 - PASS
• 1.22 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE1 - PASS
• 1.23 Kill link between spine101 and leaf2 - PASS
• 1.24 Checking topology after link down - PASS
• 1.25 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4'] with tag CASE1_Failure - FAIL
• IP connectivity failed
• 1.26 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE1_Failure - PASS
• 1.27 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE1_Failure - PASS
• 1.28 Restore link between spine101 and leaf2 - PASS
• 1.29 Check whether the flow count is >= 116 - PASS
• 1.30 Check whether all flow status are ADDED - PASS
• 1.31 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4'] with tag CASE1_Recovery - FAIL
• IP connectivity failed
• 1.32 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE1_Recovery - PASS
• 1.33 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE1_Recovery - PASS
• 1.34 Check number of topology elements - PASS
• 1.35 Stopping Mininet - PASS
• 1.36 Copying karaf logs - PASS

Case 2: Bridging and Routing Link Failure test with 4x4 Leaf-spine and 1 Onos - FAIL

• 2.1 Apply cell to environment - PASS
• 2.2 Uninstalling Atomix - PASS
• 2.3 Uninstalling ONOS package - PASS
• 2.4 Building ONOS Docker image - PASS
• 2.5 Create Cluster Config - PASS
• 2.6 Installing Atomix via docker containers - PASS
• 2.7 Installing ONOS via docker containers - PASS
• 2.8 Set up ONOS secure SSH - PASS
• 2.9 Starting ONOS CLI sessions - PASS
• 2.10 Checking ONOS nodes - PASS
• 2.11 Checking ONOS applications - PASS
• 2.12 Set logging levels - PASS
• 2.13 Set ONOS configurations - PASS
• 2.14 Starting Mininet Topology - PASS
• 2.15 Configure switches in ONOS - PASS
• 2.16 Check number of topology elements - FAIL
• Unexpected number of links, switches, and/or controllers: The number of links, switches, nodes, and SCCs does not match what was expected
• ONOS sees 8 devices (8 expected) and 24 links (32 expected) and 1 controllers (1 expected) and 3 SCCs (1 expected)
• 2.17 Check whether the flow count is >= 350 - PASS
• 2.18 Check whether all flow status are ADDED - PASS
• 2.19 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4', u'h5', u'h6', u'h7', u'h8'] with tag CASE2 - FAIL
• IP connectivity failed
• 2.20 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE2 - PASS
• 2.21 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE2 - PASS
• 2.22 Kill link between spine101 and leaf2 - PASS
• 2.23 Checking topology after link down - FAIL
• Topology after link down is incorrect
• 2.24 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4', u'h5', u'h6', u'h7', u'h8'] with tag CASE2_Failure - PASS
• 2.25 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE2_Failure - PASS
• 2.26 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE2_Failure - PASS
• 2.27 Restore link between spine101 and leaf2 - FAIL
• Failed to bring link up
• 2.28 Check whether the flow count is >= 350 - PASS
• 2.29 Check whether all flow status are ADDED - PASS
• 2.30 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4', u'h5', u'h6', u'h7', u'h8'] with tag CASE2_Recovery - PASS
• 2.31 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE2_Recovery - PASS
• 2.32 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE2_Recovery - PASS
• 2.33 Check number of topology elements - FAIL
• Unexpected number of links, switches, and/or controllers: The number of links, switches, nodes, and SCCs does not match what was expected
• ONOS sees 8 devices (8 expected) and 24 links (32 expected) and 1 controllers (1 expected) and 3 SCCs (1 expected)
• 2.34 Stopping Mininet - PASS
• 2.35 Copying karaf logs - PASS

Case 4: Bridging and Routing Link Failure test with 2x2 Leaf-spine and 3 Onos - PASS

• 4.1 Apply cell to environment - PASS
• 4.2 Uninstalling Atomix - PASS
• 4.3 Uninstalling ONOS package - PASS
• 4.4 Building ONOS Docker image - PASS
• 4.5 Create Cluster Config - PASS
• 4.6 Installing Atomix via docker containers - PASS
• 4.7 Installing ONOS via docker containers - PASS
• 4.8 Set up ONOS secure SSH - PASS
• 4.9 Starting ONOS CLI sessions - PASS
• 4.10 Checking ONOS nodes - PASS
• 4.11 Checking ONOS applications - PASS
• 4.12 Set logging levels - PASS
• 4.13 Set ONOS configurations - PASS
• 4.14 Starting Mininet Topology - PASS
• 4.15 Configure switches in ONOS - PASS
• 4.16 Check number of topology elements - PASS
• 4.17 Check whether the flow count is >= 116 - PASS
• 4.18 Check whether all flow status are ADDED - PASS
• 4.19 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4'] with tag CASE3 - PASS
• 4.20 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE3 - PASS
• 4.21 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE3 - PASS
• 4.22 Kill link between spine101 and leaf2 - PASS
• 4.23 Checking topology after link down - PASS
• 4.24 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4'] with tag CASE3_Failure - PASS
• 4.25 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE3_Failure - PASS
• 4.26 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE3_Failure - PASS
• 4.27 Restore link between spine101 and leaf2 - PASS
• 4.28 Check whether the flow count is >= 116 - PASS
• 4.29 Check whether all flow status are ADDED - PASS
• 4.30 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4'] with tag CASE3_Recovery - PASS
• 4.31 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE3_Recovery - PASS
• 4.32 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE3_Recovery - PASS
• 4.33 Check number of topology elements - PASS
• 4.34 Stopping Mininet - PASS
• 4.35 Copying karaf logs - PASS

Case 5: Bridging and Routing Link Failure test with 4x4 Leaf-spine and 3 Onos - FAIL

• 5.1 Apply cell to environment - PASS
• 5.2 Uninstalling Atomix - PASS
• 5.3 Uninstalling ONOS package - PASS
• 5.4 Building ONOS Docker image - PASS
• 5.5 Create Cluster Config - PASS
• 5.6 Installing Atomix via docker containers - PASS
• 5.7 Installing ONOS via docker containers - PASS
• 5.8 Set up ONOS secure SSH - PASS
• 5.9 Starting ONOS CLI sessions - PASS
• 5.10 Checking ONOS nodes - PASS
• 5.11 Checking ONOS applications - PASS
• 5.12 Set logging levels - PASS
• 5.13 Set ONOS configurations - PASS
• 5.14 Starting Mininet Topology - PASS
• 5.15 Configure switches in ONOS - PASS
• 5.16 Check number of topology elements - FAIL
• Unexpected number of links, switches, and/or controllers: The number of links, switches, nodes, and SCCs does not match what was expected
• ONOS sees 8 devices (8 expected) and 8 links (32 expected) and 3 controllers (3 expected) and 8 SCCs (1 expected)
• 5.17 Check whether the flow count is >= 350 - PASS
• 5.18 Check whether all flow status are ADDED - PASS
• 5.19 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4', u'h5', u'h6', u'h7', u'h8'] with tag CASE4 - FAIL
• IP connectivity failed
• 5.20 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE4 - PASS
• 5.21 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE4 - PASS
• 5.22 Kill link between spine101 and leaf2 - PASS
• 5.23 Checking topology after link down - FAIL
• Topology after link down is incorrect
• 5.24 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4', u'h5', u'h6', u'h7', u'h8'] with tag CASE4_Failure - FAIL
• IP connectivity failed
• 5.25 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE4_Failure - PASS
• 5.26 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE4_Failure - PASS
• 5.27 Restore link between spine101 and leaf2 - FAIL
• Failed to bring link up
• 5.28 Check whether the flow count is >= 350 - PASS
• 5.29 Check whether all flow status are ADDED - PASS
• 5.30 Verify full connectivity for [u'h1', u'h2', u'h3', u'h4', u'h5', u'h6', u'h7', u'h8'] with tag CASE4_Recovery - FAIL
• IP connectivity failed
• 5.31 Verify full connectivity for [u'olt10', u'vsg10'] with tag CASE4_Recovery - PASS
• 5.32 Verify full connectivity for [u'olt5', u'vsg5'] with tag CASE4_Recovery - PASS
• 5.33 Check number of topology elements - FAIL
• Unexpected number of links, switches, and/or controllers: The number of links, switches, nodes, and SCCs does not match what was expected
• ONOS sees 8 devices (8 expected) and 8 links (32 expected) and 3 controllers (3 expected) and 8 SCCs (1 expected)
• 5.34 Stopping Mininet - PASS
• 5.35 Copying karaf logs - PASS